Implementation Plan: Keep _EXEMPT_FILES Accurate and Self-Documenting After P3 Migration#3990
Merged
Trecek merged 1 commit intoJun 10, 2026
Conversation
Remove 3 stale entries that have zero AST Compare violations: - execution/backends/__init__.py: dict-key lookup, not a Compare node - cli/_marketplace.py: migrated to capability check - recipe/rules/rules_backend_compat.py: runtime var, not literal Add self-documenting inline comments to the 6 remaining entries explaining why each structural backend-name comparison is unavoidable.
Trecek
deleted the
t4-p3-a13-wp1-keep-exempt-files-accurate-and-self-documentin/3933
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 3 stale entries from
_EXEMPT_FILESintest_no_backend_name_bypass.pyand add self-documenting inline comments to the remaining 6 entries explaining why each structural backend-name comparison is unavoidable.The 3 entries to remove (
execution/backends/__init__.py,cli/_marketplace.py,recipe/rules/rules_backend_compat.py) have zero ASTCompareviolations — the exemptions were either always technically incorrect (dict-key lookup, not a Compare node) or became stale after P3 migration refactored comparisons to capability checks.The 6 remaining entries each have genuine
ast.Comparenodes referencing backend-name literals or constants, and each has a documented reason why the comparison cannot be replaced with aBackendCapabilitiesfield.Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260610-112706-148380/.autoskillit/temp/make-plan/keep_exempt_files_accurate_plan_2026-06-10_113600.mdCloses #3933
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown